Distinguish 'done' from 'configuring' in 2FA #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepeak99
approved these changes
Jul 11, 2023
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
…ipants-filter-after-click Close participants filter after click
chore: update sabre/vobject and sabre/event to latest minor
And limit it to files Signed-off-by: Louis Chemineau <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
LibreOffice only allows one invocation per user profile.[^1] The office provider set the user profile to /tmp/owncloud-instanceid and therefore only one invocation per instance is allowed. This was introduced a while ago, yet it's unclear if this was intentionally or just a side effect.[^2] The limitation on one invocation leads to the situation that the preview generation only works for a couple of files if you upload a whole folder of emf or word files. This commit removes the limitation by using a new user profile for each preview. That's done by using instance id plus file id as postfix for getTemporaryFolder. This has some drawbacks: - Overload protection: If you upload 100 emf files, you may end up with 100 LibreOffice invocations. Though, you can use preview_concurrency_new to limit the number of previews that can be generated concurrently when php-sysvsem is available. - New profile: I assume it takes a few bits to generate a fresh LibreOffice user profile. It appears that there is no way to ask LibreOffice to not create a profile and just work with the defaults. The profile will be cleaned after use by our temp manager. - Remove the configuration option preview_office_cl_parameters: This is not strictly necessary yet, but if you set the configuration option, the generated path for the user profile is also missing. The configuration option is not well documented (e.g., it's unclear that the last option needs to be --outdir) and actually, there should be no reason to change it after all. [^1]: https://wiki.documentfoundation.org/UserProfile [^2]: owncloud/core#9784 Signed-off-by: Daniel Kesselberg <[email protected]>
The initial office preview implementation converted an office document with LibreOffice to PDF, used ImageMagick to extract the first page as JPEG, and passed it OC_Image. nextcloud#10198 changed the implementation to use PNG rather than PDF. OC_Image can use a PNG as a preview right away, so the ImageMagick step is unnecessary. The registration code was updated to not ask ImageMagick if PDF is supported, as PDFs are no longer used to create office document previews. Signed-off-by: Daniel Kesselberg <[email protected]>
…oto_overlay Use background to increase overlay contrast
In order to meet accessibility requirements we cannot use a sticky footer that overlaps important interactable content. Therefore this moves to a scroll container for the details which does not include the action buttons at the bottom. Larger indentation change in SharingDetailsTab was required to have a wrapping container for the scroll area. Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Jonas <[email protected]>
…nder Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
…es_folder_icon fix(files): Show Collectives icon in Collectives folders
Fix apps search provider order
Allows to indicates if a search provider also support in app search Signed-off-by: Benjamin Gaussorgues <[email protected]>
…am-users-with-reminders fix(backupcodes): Remove old notifications before creating a new remi…
…-limit-setup-check Migrate memory_limit check to new SetupCheck API
…adataquery moving IMetadataQuery
…pSearch-method-for-advanced-search Add `inAppSearch` for advanced search providers
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
…icons Signed-off-by: Jonas <[email protected]>
fix(theming): Adjust config listener to validate `apporder` config also for closure navigation
- clean styles - lint component Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
…to_cache_events_for_metadata Listen to cache event when deleting metadata
…-follow-up-2 Enhancements: Fix and updates to most recent global search UI
…tadata_generation_job Add metadata generation job
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…st_sharing_settings Fix sharing settings unit tests
Signed-off-by: Louis Chemineau <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
…e_openfile Trigger default action when open file initial state is set
…oji-status-border fix(user_status): remove border from emoji picker
Some search providers can be hidden if they send `null` in `getOrder` Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: Benjamin Gaussorgues <[email protected]>
…ovider feat(search): hide search provider from list
…getAvatarManager Refactor `OC\Server::getAvatarManager`
….com Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
…-on-retrievemetadata get sync_token on retrieveMetadata()
…inconsitent-behavior fix(ObjectStore): Make copying behavior consistent with local storage
…ion-generation-error fix(db): Print why the migration file could not be created
…ock-admin-page-when-updater.nextcloud.com-is-down fix(updatecheck): Don't wait 120s for a response of updater.nextcloud…
Signed-off-by: MohammadReza vahedi <[email protected]> Signed-off-by: Michiel de Jong <[email protected]>
Signed-off-by: Michiel de Jong <[email protected]>
michielbdejong
force-pushed
the
mrv/tfa-configuring
branch
from
6d79ece to
d7cb86a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist