ci: migrate ocp since checker to psalm

Signed-off-by: Daniel Kesselberg <[email protected]>

autotest-checkers.sh

@@ -10,8 +10,6 @@ php ./build/triple-dot-checker.php
 RESULT=$(($RESULT+$?))
 php ./build/htaccess-checker.php
 RESULT=$(($RESULT+$?))
-php ./build/OCPSinceChecker.php
-RESULT=$(($RESULT+$?))
 php ./build/files-checker.php
 RESULT=$(($RESULT+$?))
 

build/psalm/OcpSinceChecker.php

@@ -0,0 +1,115 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @copyright 2023 Daniel Kesselberg <[email protected]>
+ *
+ * @author 2023 Daniel Kesselberg <[email protected]>
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+use PhpParser\Node\Stmt;
+use PhpParser\Node\Stmt\ClassLike;
+use Psalm\CodeLocation;
+use Psalm\DocComment;
+use Psalm\Exception\DocblockParseException;
+use Psalm\FileSource;
+use Psalm\Issue\InvalidDocblock;
+use Psalm\IssueBuffer;
+use Psalm\Plugin\EventHandler\Event\AfterClassLikeVisitEvent;
+
+class OcpSinceChecker implements Psalm\Plugin\EventHandler\AfterClassLikeVisitInterface {
+	public static function afterClassLikeVisit(AfterClassLikeVisitEvent $event): void {
+		$stmt = $event->getStmt();
+		$statementsSource = $event->getStatementsSource();
+
+		self::checkClassComment($stmt, $statementsSource);
+
+		foreach ($stmt->getMethods() as $method) {
+			self::checkMethodComment($method, $statementsSource);
+		}
+	}
+
+	private static function checkClassComment(ClassLike $stmt, FileSource $statementsSource): void {
+		$docblock = $stmt->getDocComment();
+
+		if ($docblock === null) {
+			IssueBuffer::maybeAdd(
+				new InvalidDocblock(
+					'PHPDoc is required for classes/interfaces in OCP.',
+					new CodeLocation($statementsSource, $stmt)
+				)
+			);
+			return;
+		}
+
+		try {
+			$parsedDocblock = DocComment::parsePreservingLength($docblock);
+		} catch (DocblockParseException $e) {
+			IssueBuffer::maybeAdd(
+				new InvalidDocblock(
+					$e->getMessage(),
+					new CodeLocation($statementsSource, $stmt)
+				)
+			);
+			return;
+		}
+
+		if (!isset($parsedDocblock->tags['since'])) {
+			IssueBuffer::maybeAdd(
+				new InvalidDocblock(
+					'@since is required for classes/interfaces in OCP.',
+					new CodeLocation($statementsSource, $stmt)
+				)
+			);
+		}
+	}
+
+	private static function checkMethodComment(Stmt $stmt, FileSource $statementsSource): void {
+		$docblock = $stmt->getDocComment();
+
+		if ($docblock === null) {
+			IssueBuffer::maybeAdd(
+				new InvalidDocblock(
+					'PHPDoc is required for methods in OCP.',
+					new CodeLocation($statementsSource, $stmt)
+				),
+			);
+			return;
+		}
+
+		try {
+			$parsedDocblock = DocComment::parsePreservingLength($docblock);
+		} catch (DocblockParseException $e) {
+			IssueBuffer::maybeAdd(
+				new InvalidDocblock(
+					$e->getMessage(),
+					new CodeLocation($statementsSource, $stmt)
+				)
+			);
+			return;
+		}
+
+		if (!isset($parsedDocblock->tags['since'])) {
+			IssueBuffer::maybeAdd(
+				new InvalidDocblock(
+					'@since is required for methods in OCP.',
+					new CodeLocation($statementsSource, $stmt)
+				)
+			);
+		}
+	}
+}

lib/public/Dashboard/RegisterWidgetEvent.php

@@ -41,6 +41,10 @@
 class RegisterWidgetEvent extends Event {
 	private $manager;
 
+	/**
+	 * @param IManager $manager
+	 * @since 20.0.0
+	 */
 	public function __construct(IManager $manager) {
 		parent::__construct();
 

lib/public/Files/Storage.php

@@ -462,5 +462,9 @@ public function getAvailability();
 	 */
 	public function setAvailability($isAvailable);
 
+	/**
+	 * @since 12.0.0
+	 * @return mixed
+	 */
 	public function needsPartFile();
 }

lib/public/Group/Backend/ABackend.php

@@ -33,6 +33,7 @@
 abstract class ABackend implements GroupInterface {
 	/**
 	 * @deprecated 14.0.0
+	 * @since 14.0.0
 	 *
 	 * @param int $actions The action to check for
 	 * @return bool

lib/public/User/Backend/ABackend.php

@@ -36,6 +36,7 @@
 abstract class ABackend implements IUserBackend, UserInterface {
 	/**
 	 * @deprecated 14.0.0
+	 * @since 14.0.0
 	 *
 	 * @param int $actions The action to check for
 	 * @return bool

psalm-ocp.xml

@@ -9,6 +9,7 @@
 >
 	<plugins>
 		<plugin filename="build/psalm/AppFrameworkTainter.php" />
+		<plugin filename="build/psalm/OcpSinceChecker.php" />
 	</plugins>
 	<projectFiles>
 		<directory name="lib/public"/>