Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share-with from ocm-stub to nextcloud #160

Merged
merged 62 commits into from
Jan 10, 2025
Merged

share-with from ocm-stub to nextcloud #160

merged 62 commits into from
Jan 10, 2025

Conversation

michielbdejong
Copy link
Member

On top of Mahdi's improve-shell-scripts branch.

@michielbdejong michielbdejong mentioned this pull request Jan 6, 2025
Open
4 tasks
@michielbdejong
Copy link
Member Author

I should add PROPFIND to OcmStub, otherwise NC v28 will reject the share from it.

@michielbdejong
Copy link
Member Author

michielbdejong commented Jan 6, 2025 •
edited
Loading

Strategy:

  • ./dev/ocm-test-suite.sh share-with nextcloud v28.0.14 dev electron nextcloud v28.0.14
  • add error_log($_SERVER, true)); to index.php, public.php and remote.php
  • get a curl command for the PROPFIND call
  • make OcmStub respond correctly to PROPFIND calls

@michielbdejong
Copy link
Member Author

Live-journalling this in tubsproject/devlog#11

@michielbdejong
Copy link
Member Author

Blocked on michielbdejong/ocm-stub#8

@michielbdejong michielbdejong mentioned this pull request Jan 6, 2025
Closed
2 tasks
@michielbdejong michielbdejong changed the title First attempt at ocmstub -> nextcloud share-with share-with from ocm-stub Jan 6, 2025
@michielbdejong michielbdejong changed the title share-with from ocm-stub share-with from ocm-stub to nextcloud Jan 7, 2025
@michielbdejong michielbdejong mentioned this pull request Jan 7, 2025
Merged
@michielbdejong michielbdejong mentioned this pull request Jan 7, 2025
Merged
michielbdejong and others added 20 commits January 8, 2025 15:39
@michielbdejong
try to get share-link nc27 -> os1 working
5903fdf
@michielbdejong
specify missing DOCKER_NETWORK env var
2d1b046
@michielbdejong
Update script for dev/ocm-test-suite/share-link/nextcloud-nextcloud.sh
f4846a7
@michielbdejong
share-link NC27 -> OS1, the new way
4448112
@michielbdejong
Update share-with -> share-link in copied file
7883e78
@michielbdejong
Use variables
349cd62
@michielbdejong
allowNcDivergence
5f183a0
@MahdiBaghbani @michielbdejong
fix: JSONArgsRecommended by specifying a SHELL before CMD
b088930
@MahdiBaghbani @michielbdejong
add: authors in header
f5b962d
@MahdiBaghbani @michielbdejong
add: argument in docstrings and TODO comment for future
1c66697
@MahdiBaghbani @michielbdejong
add: GtiHub actions test runner
4afd528
@MahdiBaghbani @michielbdejong
modify: use first instead of each
15d0424
@MahdiBaghbani @michielbdejong
add: authors
3c41f82
@MahdiBaghbani @michielbdejong
add: GtiHub actions workflow
8aa70a2
@MahdiBaghbani
add: docs and ensure file exists
41d8086
@MahdiBaghbani
fix: authors header
515da4d
@MahdiBaghbani
Merge branch 'share-with-from-ocm-stub' into share-with-stub-oc10
1f46e15
@MahdiBaghbani
fix: comments and header
bf8674b
@MahdiBaghbani
add: GitHub Actions workflows
1580597
@MahdiBaghbani @michielbdejong
Merge pull request #167 from pondersource/share-with-stub-oc10
8ec2d6c 
ocmstub-v1-to-owncloud-v10 take 2

Co-authored-by: Michiel B. de Jong <[email protected]>
@MahdiBaghbani
Copy link
Member

I'm changing some parts of this branch, please do not merge

@michielbdejong
Copy link
Member Author

I also added 7972b51 in combination with pondersource/ocm-stub@077ec41

I think we should remove the .first because it should not be necessary now anymore, and it will help us to detect problems early if this happens again

MahdiBaghbani
MahdiBaghbani approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@MahdiBaghbani MahdiBaghbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MahdiBaghbani MahdiBaghbani merged commit be6e591 into improve-shell-scripts Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBaghbani MahdiBaghbani MahdiBaghbani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michielbdejong @MahdiBaghbani