Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config validation and reloading #495

Merged
merged 28 commits into from
Dec 13, 2023
Merged

Config validation and reloading #495

merged 28 commits into from
Dec 13, 2023

Conversation

kyscott18
Copy link
Collaborator

@kyscott18 kyscott18 commented Dec 9, 2023 •
edited
Loading

Fix several bugs around config validation:

  • Explicitly validate both config and schema in the build pipeline
  • Stricter typing on config, with more tests
  • Gracefully handle ABIs with unnamed parameters
  • Reload ponder app on both config and schema changes, handling errors without shutting down the dev server
  • Handle invalid and default rpc urls
  • Realtime sync setup sequence retry logic (occurs with free rpc providers)

Closes #479

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: eace84e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ponder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 9:59pm

@kyscott18 kyscott18 marked this pull request as ready for review December 11, 2023 21:04
@kyscott18 kyscott18 changed the title [WIP]Config validation and reloading Config validation and reloading Dec 11, 2023
0xOlias
0xOlias approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@0xOlias 0xOlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nits. Looks great!

packages/core/src/Ponder.ts Outdated Show resolved Hide resolved
packages/core/src/Ponder.ts Outdated Show resolved Hide resolved
packages/core/src/Ponder.ts Outdated Show resolved Hide resolved
packages/core/src/Ponder.ts Show resolved Hide resolved
packages/core/src/build/service.ts Show resolved Hide resolved
@kyscott18 kyscott18 merged commit 7fdbde6 into main Dec 13, 2023
8 of 10 checks passed
@kyscott18 kyscott18 deleted the kjs/config-validate branch December 13, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOlias 0xOlias 0xOlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config validation
2 participants
@kyscott18 @0xOlias