Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reloading ponder.config.ts restarts the ponder app #466

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Reloading ponder.config.ts restarts the ponder app #466

merged 3 commits into from
Dec 4, 2023

Conversation

bankisan
Copy link
Contributor

@bankisan bankisan commented Nov 27, 2023 •
edited
Loading

Changes

  • Add setup() method to server service to replicate interface of other services
  • Reload ponder app when config file changes rather than exiting
  • resetMetrics() method to metrics service

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 36c383d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ponder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 5:51pm

@bankisan bankisan marked this pull request as ready for review November 27, 2023 17:51
@bankisan bankisan mentioned this pull request Nov 29, 2023
Merged
0xOlias
0xOlias approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@0xOlias 0xOlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and works great!

@bankisan bankisan merged commit 96a5321 into main Dec 4, 2023
10 checks passed
@bankisan bankisan deleted the bankisan/ponder-config-reload branch December 4, 2023 18:20
This was referenced Dec 4, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOlias 0xOlias 0xOlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bankisan @0xOlias