Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the runtime context object to match PonderApp #415

Merged
merged 18 commits into from
Nov 10, 2023

Conversation

kyscott18
Copy link
Collaborator

@kyscott18 kyscott18 commented Nov 9, 2023

The context object, passed into indexing functions, now matches the shaped of the data defined in PonderApp. This also updates the intermediate representation of config, performing validation in the createConfig() function. Fixes a bug with the strictness of types when filtering on a event with know args.

Closes #400 and closes #394

Copy link

railway-app bot commented Nov 9, 2023

This PR was not deployed automatically as @kyscott18 does not have access to the Railway project.

In order to get automatic PR deploys, please add @kyscott18 to the project inside the project settings page.

Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: 6802b5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ponder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 1:12am

Copy link
Collaborator

@0xOlias 0xOlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyscott18 kyscott18 merged commit cf6340f into main Nov 10, 2023
6 of 9 checks passed
@kyscott18 kyscott18 deleted the kjs/create-config-validation branch November 10, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add cache-enabled PublicClient + ABIs to context Is ChainID exposed?
2 participants