Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config #406

Merged
merged 36 commits into from
Nov 7, 2023
Merged

Refactor config #406

merged 36 commits into from
Nov 7, 2023

Conversation

kyscott18
Copy link
Collaborator

@kyscott18 kyscott18 commented Nov 3, 2023 •
edited
Loading

Update the config to combine filter and contracts into one field, strictly type with inference using a function. Temporarily changed the context object and removed the contracts property.

Closes #403 and closes #398

@railway-app Railway App
Copy link

railway-app bot commented Nov 3, 2023

This PR was not deployed automatically as @kyscott18 does not have access to the Railway project.

In order to get automatic PR deploys, please add @kyscott18 to the project inside the project settings page.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: bee9a37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ponder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 5:23pm

@kyscott18 kyscott18 marked this pull request as ready for review November 6, 2023 22:12
0xOlias
0xOlias approved these changes Nov 6, 2023
View reviewed changes
packages/core/src/config/config.ts
Comment on lines +40 to +41
FormatAbiItem<First> extends `event ${infer LongEvent extends string}`
? readonly [LongEvent, ...SafeEventNames<Rest, TArr>]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that syntax highlighting stops working here (on the GH diff viewer)

packages/core/src/config/sources.ts Outdated Show resolved Hide resolved
packages/core/src/config/sources.ts

return contracts
.map((contract) => {
// Note: should we filter down which indexing functions are available based on the filters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call!

packages/core/src/config/sources.ts Show resolved Hide resolved
packages/core/src/config/sources.ts Outdated Show resolved Hide resolved
packages/core/src/config/sources.ts Outdated Show resolved Hide resolved
packages/core/src/config/sources.ts Outdated Show resolved Hide resolved
packages/core/src/config/sources.ts Outdated Show resolved Hide resolved
packages/core/src/event-store/postgres/migrations.ts Outdated Show resolved Hide resolved
0xOlias
0xOlias approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@0xOlias 0xOlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyscott18 kyscott18 merged commit 584b541 into main Nov 7, 2023
5 of 9 checks passed
@kyscott18 kyscott18 deleted the config-refactor branch November 7, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOlias 0xOlias 0xOlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kyscott18 @0xOlias