Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding filter by SHA for bug fixes table #184

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

y3pio
Copy link
Collaborator

@y3pio y3pio commented Jan 17, 2025

PR Summary

Adding filter by SHA input option on the bug_fixes table.

Details

Testing/QA

  • Tested locally, screencap below.
Screen.Recording.2025-01-17.at.12.44.43.PM.mov

@y3pio y3pio requested a review from khatchad January 17, 2025 17:47
@y3pio y3pio mentioned this pull request Jan 17, 2025
@khatchad
Copy link
Member

@y3pio Does this solve an issue? If so, could you please reference it in the description? Also, is this a feature, can a feature label added and the term "feat" removed from the title? Lastly, it would be good to verify this on a dev deployment instead of just locally. Thanks!

@y3pio y3pio added the enhancement New feature or request label Jan 18, 2025
@y3pio y3pio changed the title feat: adding filter by SHA for bug fixes table adding filter by SHA for bug fixes table Jan 18, 2025
@y3pio
Copy link
Collaborator Author

y3pio commented Jan 18, 2025

@y3pio Does this solve an issue? If so, could you please reference it in the description? Also, is this a feature, can a feature label added and the term "feat" removed from the title? Lastly, it would be good to verify this on a dev deployment instead of just locally. Thanks!

Yup, removed the feat from the title and added an enhancement label.

Lastly, it would be good to verify this on a dev deployment instead of just locally. Thanks!

I think we'll need to setup the Heroku deploy again, can create an issue for this!

@y3pio y3pio mentioned this pull request Jan 18, 2025
@khatchad
Copy link
Member

@y3pio Does this solve an issue? If so, could you please reference it in the description? Also, is this a feature, can a feature label added and the term "feat" removed from the title? Lastly, it would be good to verify this on a dev deployment instead of just locally. Thanks!

Yup, removed the feat from the title and added an enhancement label.

You can create a "feature" label.

Lastly, it would be good to verify this on a dev deployment instead of just locally. Thanks!

I think we'll need to setup the Heroku deploy again, can create an issue for this!

Thanks. I think that this should be done before any other work.

@y3pio y3pio added feature New feature work. and removed enhancement New feature or request labels Jan 21, 2025
@y3pio y3pio force-pushed the ypaing/161-filter-by-sha branch from 645c12f to 9f38136 Compare January 29, 2025 05:48
@y3pio
Copy link
Collaborator Author

y3pio commented Jan 30, 2025

Merging this to test Heroku deployment setup.

@y3pio y3pio merged commit ecdbaee into main Jan 30, 2025
1 check passed
@y3pio y3pio deleted the ypaing/161-filter-by-sha branch January 30, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants