Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete categorizations in test setup #156

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

ZhongweiL
Copy link
Contributor

resolves the bug in PR #148 with deleting categorizers by making sure the categorization table is empty in test setup

@khatchad
Copy link
Member

khatchad commented Dec 7, 2021

Thanks.

@khatchad khatchad merged commit 83be5c1 into ponder-lab:main Dec 7, 2021
@khatchad
Copy link
Member

khatchad commented Dec 7, 2021

@ZhongweiL , please watch the tests and let me know if they pass.

@ZhongweiL
Copy link
Contributor Author

@khatchad They shouldn't pass because we're writing tests before implementing the changes, but I don't think I understand the error message, they seem like some low-level issues with Django.

@khatchad khatchad deleted the fix_test branch December 7, 2021 23:25
@khatchad khatchad restored the fix_test branch December 7, 2021 23:25
@khatchad
Copy link
Member

khatchad commented Dec 7, 2021

@khatchad
Copy link
Member

khatchad commented Dec 7, 2021 via email

@khatchad
Copy link
Member

khatchad commented Dec 7, 2021 via email

@ZhongweiL
Copy link
Contributor Author

What changes haven't you implemented? Raffi Khatchadourian @.> Assistant Professor, Computer Science, Hunter College Doctoral Faculty of the Graduate School and University Center's Ph.D. Program in Computer Science City University of New York (CUNY) http://cs.hunter.cuny.edu/~Raffi.Khatchadourian99 On Dec 7, 2021 5:51 PM, Zhongwei Li @.> wrote: @khatchadhttps://github.com/khatchad They shouldn't pass because we're writing tests before implementing the changes, but I don't think I understand the error message, they seem like some low-level issues with Django. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#156 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAPUGP37GTFSUFUNSCKLVATUP2FXXANCNFSM5JSLMNHA.

@khatchad Never mind, the changes for this test have been implemented in the model and merged, but I don't think it has been migrated to the remote database, which may indicate that the automatic deployment has failed. Or it might be because that the automatic deployment was added after the change was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants