Updates the Categorizers table when a user is added or removed as a categorizer #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the above errors. Also, did you test this code? Can any new test code be written for this code (unit tests)? Please do not submit PRs without testing the code first. Please make sure that your tests cover the new code. You can actually achieve this with unit testing. |
|
So, for example, you can make a test called |
|
I tested it but not with unit tests, I'll try to write some tests for it. |
khatchad
reviewed
Nov 5, 2021
| @@ -70,6 +72,10 @@ class Meta: | |||
| def __str__(self): | |||
| return self.user | |||
|
|
|||
| @receiver(m2m_changed) | |||
There was a problem hiding this comment.
The relationship between categorizers and Django users is 1:1 not N:N (or M:M).
|
@ZhongweiL Can you give us a status update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intends to resolve issue #132