Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cmake_minimum_version from 3.0 to 3.10 to work with latest NDK's #26

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

shreyaspranav
Copy link
Contributor

When used with the Android NDK version 27.0.12077973, the gradle sync fails with the following error:

CMake Error at D:/AndroidSDK/ndk/27.0.12077973/build/cmake/flags.cmake:46 (if):
  if given arguments:

    "hwaddress" "IN_LIST" "ANDROID_SANITIZE"

When cmake_minimum_required is changed form version 3.0 to '3.10` the above error will be fixed.

@polymonster
Copy link
Owner

Ok, happy to take this for now. There have been a few times in the past where people suggest bumping the cmake version. Ideally there should be an option to set it from the premake config.

If you fancy adding a cmake_minimum_required option that would be helpful for future, I will try and get round to it myself sometime but if you get there first I will happily accept the contribution.

Thanks

@polymonster polymonster merged commit 138a1e0 into polymonster:master Aug 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants