Make onMutate compare objects deeply when deciding to trigger the c…

…allback Signed-off-by: William So <[email protected]>
polyipseity · Sep 30, 2023 · 33bf954 · 33bf954
1 parent 88b03ba
commit 33bf954
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/mighty-hairs-cover.md b/.changeset/mighty-hairs-cover.md
@@ -0,0 +1,5 @@
+---
+"@polyipseity/obsidian-plugin-library": minor
+---
+
+Make `onMutate` compare objects deeply when deciding to trigger the callback.
diff --git a/sources/settings.ts b/sources/settings.ts
@@ -71,8 +71,8 @@ export abstract class AbstractSettingsManager<T extends AbstractSettingsManager
 				const settings = this.value,
 					cur = accessor(settings),
 					prev0 = prev
-				if (prev0 !== cur) {
-					prev = cur
+				prev = cur
+				if (!deepEqual(cur, prev0, { strict: true })) {
 					await callback(cur, prev0, settings)
 				}
 			})