Include well-known PalletVersion storage function (#322)

polkascan · Feb 21, 2023 · b96c612 · b96c612
1 parent c809965
commit b96c612
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/requirements.txt b/requirements.txt
@@ -11,7 +11,7 @@ eth_utils>=1.3.0,<3
 pycryptodome>=3.11.0,<4
 PyNaCl>=1.0.1,<2
 
-scalecodec>=1.2,<1.3
+scalecodec>=1.2.1,<1.3
 py-sr25519-bindings>=0.2.0,<1
 py-ed25519-zebra-bindings>=1.0,<2
 py-bip39-bindings>=0.1.9,<1

diff --git a/setup.py b/setup.py
@@ -188,7 +188,7 @@
         'eth_utils>=1.3.0,<3',
         'pycryptodome>=3.11.0,<4',
         'PyNaCl>=1.0.1,<2',
-        'scalecodec>=1.2,<1.3',
+        'scalecodec>=1.2.1,<1.3',
         'py-sr25519-bindings>=0.2.0,<1',
         'py-ed25519-zebra-bindings>=1.0,<2',
         'py-bip39-bindings>=0.1.9,<1'

diff --git a/substrateinterface/base.py b/substrateinterface/base.py
@@ -1438,7 +1438,7 @@ def subscription_handler(obj, update_nr, subscription_id):
 
             storage_hash = self.generate_storage_hash(
                 storage_module=metadata_module.value['storage']['prefix'],
-                storage_function=storage_function,
+                storage_function=storage_item.value['name'],
                 params=params,
                 hashers=hashers
             )

diff --git a/test/test_query.py b/test/test_query.py
@@ -110,6 +110,14 @@ def test_well_known_keys_not_found(self):
         with self.assertRaises(StorageFunctionNotFound):
             self.kusama_substrate.query("Substrate", "Unknown")
 
+    def test_well_known_pallet_version(self):
+
+        sf = self.kusama_substrate.get_metadata_storage_function("System", "PalletVersion")
+        self.assertEqual(sf.value['name'], ':__STORAGE_VERSION__:')
+
+        result = self.kusama_substrate.query("System", "PalletVersion")
+        self.assertGreaterEqual(result.value, 0)
+
 
 if __name__ == '__main__':
     unittest.main()