Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ethereum to cli signer #220

Merged
merged 6 commits into from
Jul 30, 2021
Merged

Add ethereum to cli signer #220

merged 6 commits into from
Jul 30, 2021

Conversation

joelamouche
Copy link
Contributor

@joelamouche joelamouche commented Mar 8, 2021

tackles #219

@joelamouche joelamouche marked this pull request as draft March 8, 2021 13:40
@joelamouche joelamouche changed the title added ethereum Add ethereum to cli signer May 18, 2021
packages/api-cli/src/api.ts Outdated Show resolved Hide resolved
Comment on lines +179 to +182
},
null,
2
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting here is quite weird, not sure why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither. The linter doesn't complain

packages/api-cli/src/api.ts Outdated Show resolved Hide resolved
packages/api-cli/src/api.ts Outdated Show resolved Hide resolved
@joelamouche joelamouche marked this pull request as ready for review June 22, 2021 09:42
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jacogr jacogr merged commit c99d279 into polkadot-js:master Jul 30, 2021
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants