-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of the extension landing page #1414
base: master
Are you sure you want to change the base?
Conversation
IMHO, this is a pretty bad (and ugly) way of doing something that's been discussed for a while, which is to de-rank the pjs products such as |
There's no point at all in trying to make the extension landing page beautiful. It's not like the current landing page is an artistic marvel either. The rename effort is completely unrelated to this PR, this is about pointing to ecosystem wallets first, c'est tout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stands, this page ranks very high for "Polkadot wallet".
Then let's change this. There are also many ppl who land here bc they click on links, what you propose here is a horrendous UX. Let's fix the problem at the source.
From where I'm standing it just seems my design skills gave you some grief and are distracting you from the goal this aims to achieve: default redirection to ecosystem wallets. If you have constructive suggestions about what is good UX to achieve that, feel free to push your code. We all have opinions, valid or not, but what matters in the end is code, results and time. The rename/rebrand will be discussed separately, but meanwhile we don't have to wait for the future to fix the issues we know about today. Otherwise, this PR will serve as prime example for why in 2024 people still install the pjs extension by mistake when searching for "Polkadot Wallet" and clicking on https://polkadot.js.org/extension/ , which I remind you is the 2nd hit on Google, and was so for the past couple of years. |
You don't get it. I'm not talking about your UI (the ugly buttons). I'm talking about the wrong solution to the problem, on top of adding a pretty unconventional UX, clicking twice on a button. This behavior is done in applications for very specific cases, when ppl are about to do something dangerous, e.g delete something irreversibly etc. This is not a good solutions to the problems, as I said. The problem is stated very clearly in your messages:
I'm repeating myself here. This is a ranking issue. Let's solve it, instead of providing a bad UX for all users, the ones who don't know, and the ones who know what pjs extension is for. A lot of work has been done on the wallet page of Polkadot.network, and this is now rank 1. This was not the case before. |
I respect your opinion, but unless you have an actual solution to propose to this specific problem or the other problem you're conflating with this one, don't further derail this PR. I really don't see the utility in yak shaving the UX of a landing page that people shouldn't land on at all.
It's a lot of work yes, but so far your comments have been using "ugly, bad, horrendous, unconventional" without providing a hint of actionable insight, quite the opposite of being constructive or helpful. This isn't the developer experience we should aim for. After all, we should leave the SEO ranking part to the experts. Ranking is something that requires coordinated effort and a lot of time, as other websites still link to the extension page and contribute to the ranking. Certainly something needs to be done about the ranking in a next step and the design can be improved iteratively, it's the beauty of open source code. I'm looking forward to your plan and link to your PR for the ranking ;) Meanwhile, I have outlined the steps of that plan in our telegram chat a month ago, am executing it, and welcome your contributions. What is sure is that it's out of scope for this PR, so stop trying to make it about that. This PR is to address redirection of people that land on the landing page, not the way how they get there... |
Gimmie a few days ;) Will propose an alternative |
Please don't take my words as attacks to you or this PR. I've mentioned it many times by now, my feelings about the design have nothing to do with this PR, and I should have left them aside, you're right. UX matters to me though, and I believe there are better ways to achieve the same goal, see below. You chose to go with a PR, rather than an issue + discussion, so we end up discussing in the PR. A closed Tg channel is certainly not the best way to discuss. I gave you many areas where I think the solutions should go, please take a moment to see them, they are in my past comments:
Very important also:
I agree things should change, and I'm happy to contribute to the discussion and the code, as I did in the past, once we agree on a path forward. |
As it stands, this page ranks very high for "Polkadot wallet".
We'll use this as a distribution channel to guide users to ecosystem wallets linked prominently.
The developer extension is still accessible after a small hurdle.
extension-2024-07-25_17.50.01.mp4