-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Staking Next Page #11483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Staking Next Page #11483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…th improved state management
…ropdown for API selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I have a few nip picks, please address them.
@@ -34,6 +34,7 @@ | |||
"nav.signing": "Sign and verify", | |||
"nav.society": "Society", | |||
"nav.staking": "Staking", | |||
"nav.staking-next": "Staking Next", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming the Section Staking Next might be confusing for anyone outside of the context of this task, can be rename it to something more descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do here 🤔, this is basically route name & "Staking Next" is the term we are using now.
📝 Description
This PR aims to create a new staking page (Staking Next) for Asset Hub migration. The main idea here is to add "Staking Next Command Center" and makes other tabs compatble with new storage/pallets.
The core implementation is done with this - https://hackmd.io/7PiBrGxxRG2ib-WRZYJZhQ