Skip to content

Staking Next Page #11483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Staking Next Page #11483

wants to merge 38 commits into from

Conversation

ap211unitech
Copy link
Member

@ap211unitech ap211unitech commented Apr 15, 2025

📝 Description

This PR aims to create a new staking page (Staking Next) for Asset Hub migration. The main idea here is to add "Staking Next Command Center" and makes other tabs compatble with new storage/pallets.

The core implementation is done with this - https://hackmd.io/7PiBrGxxRG2ib-WRZYJZhQ

@ap211unitech ap211unitech self-assigned this May 8, 2025
@ap211unitech ap211unitech marked this pull request as ready for review May 11, 2025 18:05
Copy link
Contributor

@valentinfernandez1 valentinfernandez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR were originally targeting this PR , which has since been closed in favor of a new one.

Please verify that the Staking Command Center remains compatible with the new branch, or update it accordingly if needed.

@valentinfernandez1 valentinfernandez1 self-requested a review May 20, 2025 15:18
Copy link
Contributor

@valentinfernandez1 valentinfernandez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I have a few nip picks, please address them.

@@ -34,6 +34,7 @@
"nav.signing": "Sign and verify",
"nav.society": "Society",
"nav.staking": "Staking",
"nav.staking-next": "Staking Next",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming the Section Staking Next might be confusing for anyone outside of the context of this task, can be rename it to something more descriptive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to do here 🤔, this is basically route name & "Staking Next" is the term we are using now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants