Skip to content

feat: Add initial support for Metadata V16 view_functions #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

demoncoder-crypto
Copy link

Addresses #6133

@valentinfernandez1
Copy link
Contributor

Thanks for putting this together, I appreciate the effort here.

That said, I think the approach might need to be rethought a bit. A lot of the files touched in this PR are auto-generated (they explicitly state // Auto-generated via yarn polkadot-types-from-defs, do not edit) and so editing them directly isn’t the right path.

Also, some of what’s being added here overlaps with the upcoming Metadata V16 PR so it probably makes more sense to wait until that lands, then build on top of it, otherwise we risk redoing work or introducing conflicts. Not saying that this effort isn't valuable but it might be a good idea to hold off until the Metadata 16 stuff is merged

@demoncoder-crypto
Copy link
Author

Understood I will wait till metadata V16 Pr, also please tell on what changes or what tangent do you want me to implement the changes I am very willing to make the desired changes. Thanks :). @valentinfernandez1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants