-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cache key #5745
fix cache key #5745
Conversation
@jacogr can you check this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this locally, and debugged with DEBUG=api-ws
and it checks out. Thanks for the PR!
It would be nice if the CI could run against this again since none of the actions are visible... Looking into this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks fine, but I would like the workflows to run before we merge... Very odd indeed.
maybe this PR is very old. I will do a master pull |
Sounds perfect! Was just going to ask the same thing :) Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 🚀 Thanks for the PR!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Cache is never read because we're using
body
as key which includesid
.