Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cache key #5745

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix cache key #5745

merged 2 commits into from
Mar 4, 2024

Conversation

ermalkaleci
Copy link
Contributor

Cache is never read because we're using body as key which includes id.

@ermalkaleci
Copy link
Contributor Author

@jacogr can you check this?

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this locally, and debugged with DEBUG=api-ws and it checks out. Thanks for the PR!

@TarikGul
Copy link
Member

TarikGul commented Mar 4, 2024

It would be nice if the CI could run against this again since none of the actions are visible...

Looking into this

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks fine, but I would like the workflows to run before we merge... Very odd indeed.

@ermalkaleci
Copy link
Contributor Author

The PR looks fine, but I would like the workflows to run before we merge... Very odd indeed.

maybe this PR is very old. I will do a master pull

@TarikGul
Copy link
Member

TarikGul commented Mar 4, 2024

The PR looks fine, but I would like the workflows to run before we merge... Very odd indeed.

maybe this PR is very old. I will do a master pull

Sounds perfect! Was just going to ask the same thing :) Thanks

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚀 Thanks for the PR!

@TarikGul TarikGul merged commit ea2c942 into polkadot-js:master Mar 4, 2024
4 checks passed
@ermalkaleci ermalkaleci deleted the fix-cache-key branch March 4, 2024 16:59
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants