Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Add ndtri, igam, chdtr #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lericson
Copy link

No description provided.

@astrojuanlu
Copy link
Member

Thanks a lot for this pull request @lericson! Are you planning to add more functions? What is the scope of the changes you would like to make in the repository?

@lericson
Copy link
Author

lericson commented Nov 29, 2016 via email

@astrojuanlu
Copy link
Member

Ideally we would find a better way to add the CFFI boilerplate; the process is a bit tedious at the moment, and I don’t see why it has to be!

Exactly! I think it would be nice to automate at least part of this process, but now I don't have the time resources to do it. In any case, when you think this pull request is ready to review please ping me, we can check the code together and I will be happy to merge :)

@astrojuanlu
Copy link
Member

Other than that, adding automation functionality can go in a separate PR.

@lericson
Copy link
Author

lericson commented Nov 29, 2016 via email

@lericson
Copy link
Author

lericson commented Nov 29, 2016 via email

@astrojuanlu
Copy link
Member

Or perhaps this can be used instead http://numba.pydata.org/numba-doc/0.29.0/user/vectorize.html but requires a totally different approach.

@lericson
Copy link
Author

lericson commented Nov 29, 2016 via email

@astrojuanlu
Copy link
Member

I just realized that the project already requires numba, so it's fine to use it to vectorize the functions. At the end of this PR there should be:

  • Scalar and vector tests for all the functions
  • More benchmarks
  • An updated README

@astrojuanlu
Copy link
Member

And by the way, I can focus on providing Travis CI integration so we can monitor the progress of this: #4

@lericson
Copy link
Author

😟

@lericson lericson changed the title Add ndtri Add ndtri, igam, chdtr Nov 29, 2016
@lericson
Copy link
Author

lericson commented Nov 29, 2016

It might be nice to put all the ndtr and ndtri functions inside a norm module to mimic Scipy like I did with chi2 here.

@astrojuanlu
Copy link
Member

😟

Fear not, we'll get there 😄

@astrojuanlu
Copy link
Member

This project is not maintained anymore, please check out https://github.com/limix/ncephes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants