Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

CI Fixes #138

Merged
merged 6 commits into from
Jun 25, 2024
Merged

CI Fixes #138

merged 6 commits into from
Jun 25, 2024

Conversation

Stoops-ML
Copy link
Collaborator

This PR also fixes Codecov reports.

@Stoops-ML
Copy link
Collaborator Author

Codecov still hasn't commented it's report on this PR. Seems like I've missed something again.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (b03f228) to head (3eda138).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #138       +/-   ##
===========================================
+ Coverage   48.53%   99.26%   +50.72%     
===========================================
  Files          11       13        +2     
  Lines        1125      811      -314     
===========================================
+ Hits          546      805      +259     
+ Misses        579        6      -573     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stoops-ML
Copy link
Collaborator Author

Codecov is commenting and showing the correct coverage. A v1.0.0 tag is attached to the last commit which should trigger the publish to PyPi action.

@astrojuanlu
Copy link
Member

Can we instead separate the CI fixes from the actual bump?

Also, maybe tagging the last commit with v1.0.0 is a bad practice. What if there are review comments etc? We'd need to un-tag and tag commits constantly. Maybe a better way would be to make the PR, merge it, and then we tag the corresponding commit in main.

@Stoops-ML
Copy link
Collaborator Author

Also, maybe tagging the last commit with v1.0.0 is a bad practice. What if there are review comments etc? We'd need to un-tag and tag commits constantly. Maybe a better way would be to make the PR, merge it, and then we tag the corresponding commit in main.

I didn't do this because the publish to PyPi action only runs on push, and I'm unsure if tagging the commit in main is considered a push.

I'll remove the v1.0.0 tag so the publish to PyPi action won't be run. Once this PR is merged you can tag the last commit in main and we'll see if the publish to PyPi action is triggered. If it's not triggered, I'll have to do some research in the best practices.

@Stoops-ML
Copy link
Collaborator Author

v1.0.0 deleted.

@Stoops-ML
Copy link
Collaborator Author

Stoops-ML commented Jun 25, 2024

This seems good for publishing to PyPi. It runs the publish to PyPi action on a release (instead of on push, which is the current implementation). Should I implement this (as another PR)?

@Stoops-ML Stoops-ML changed the title Bump to v1.0.0 CI Fixes Jun 25, 2024
@Stoops-ML
Copy link
Collaborator Author

Ready for merge, followed by a release. This will be the first release since 14th December 2021!

@astrojuanlu
Copy link
Member

Well, let's try! 🔥

@astrojuanlu astrojuanlu merged commit a1357e3 into main Jun 25, 2024
8 checks passed
@astrojuanlu astrojuanlu deleted the v1.0.0 branch June 25, 2024 16:24
@astrojuanlu
Copy link
Member

@Stoops-ML please do the honors and proceed with the release if you have enough permissions :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants