-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
Codecov still hasn't commented it's report on this PR. Seems like I've missed something again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
===========================================
+ Coverage 48.53% 99.26% +50.72%
===========================================
Files 11 13 +2
Lines 1125 811 -314
===========================================
+ Hits 546 805 +259
+ Misses 579 6 -573
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov is commenting and showing the correct coverage. A v1.0.0 tag is attached to the last commit which should trigger the publish to PyPi action. |
Can we instead separate the CI fixes from the actual bump? Also, maybe tagging the last commit with |
I didn't do this because the publish to PyPi action only runs on push, and I'm unsure if tagging the commit in I'll remove the |
|
This seems good for publishing to PyPi. It runs the publish to PyPi action on a release (instead of on push, which is the current implementation). Should I implement this (as another PR)? |
Ready for merge, followed by a release. This will be the first release since 14th December 2021! |
Well, let's try! 🔥 |
@Stoops-ML please do the honors and proceed with the release if you have enough permissions :) |
This PR also fixes Codecov reports.