Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tax applicability to Product #4669

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Move tax applicability to Product #4669

merged 3 commits into from
Dec 17, 2024

Conversation

frankie567
Copy link
Member

Fix #4613

@frankie567
server/product: add is_tax_applicable to product directly
974c4ef 
We don't want to rely on benefits anymore for now, since we've seen cases of Product without any benefit.

For compliance issues, we prefer to put `is_tax_applicable` to `True` by default on every products, and manually review upon request the ones that may be exempted from it.
@frankie567
clients/sdk: update OpenAPI client
fecb0a9
@frankie567 frankie567 enabled auto-merge (rebase) December 17, 2024 16:41
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:18pm
polar-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:18pm

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 154.46 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Hundred Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/layout 110.8 KB 265.26 KB 75.79% (🟢 -0.02%)
/checkout/[clientSecret]/confirmation/page 269.16 KB 423.62 KB 121.04% (🟢 -0.02%)
/checkout/[clientSecret]/page 261.06 KB 415.52 KB 118.72% (🟢 -0.01%)
/(main)/layout 79.98 KB 234.44 KB 66.98% (🟢 -0.01%)
/(main)/signup/page 135.04 KB 289.5 KB 82.71% (🟢 -0.01%)
/(main)/login/page 161.08 KB 315.54 KB 90.16% (🟢 -0.02%)
/(main)/login/magic-link/request/page 361 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/(installation)/github/installation/page 128.87 KB 283.33 KB 80.95% (🟢 -0.01%)
/(main)/(topbar)/layout 240.74 KB 395.2 KB 112.92% (🟢 -0.02%)
/(main)/[organization]/(header)/page 134.78 KB 289.24 KB 82.64% (🟢 -0.01%)
/(main)/[organization]/(header)/layout 265.4 KB 419.85 KB 119.96% (🟢 -0.02%)
/(main)/[organization]/(header)/products/[productId]/page 191.86 KB 346.32 KB 98.95% (🟢 -0.02%)
/(main)/[organization]/(header)/issues/page 122.15 KB 276.61 KB 79.03% (🟢 -0.01%)
/(main)/[organization]/(header)/subscriptions/page 360 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/[organization]/[repo]/issues/[number]/(create)/page 194.91 KB 349.37 KB 99.82% (🟢 -0.01%)
/(main)/[organization]/[repo]/layout 232.18 KB 386.64 KB 110.47% (🟢 -0.01%)
/(main)/[organization]/[repo]/issues/[number]/status/page 228.43 KB 382.89 KB 109.40% (🟢 -0.02%)
/(main)/[organization]/portal/request/page 67.14 KB 221.6 KB 63.31% (🟢 -0.01%)
/(main)/[organization]/portal/orders/[id]/page 195.2 KB 349.66 KB 99.90% (🟢 -0.01%)
/(main)/[organization]/[repo]/page 205.05 KB 359.51 KB 102.72% (🟢 -0.02%)
/(main)/[organization]/portal/subscriptions/[id]/page 199.56 KB 354.02 KB 101.15% (🟢 -0.02%)
/(main)/[organization]/portal/page 106.25 KB 260.71 KB 74.49% (🟢 -0.02%)
/(main)/[organization]/portal/authenticate/page 70.85 KB 225.31 KB 64.38% (🟢 -0.02%)
/(main)/backoffice/rebadge/page 40.59 KB 195.05 KB 55.73% (🟢 -0.01%)
/(main)/backoffice/layout 565.79 KB 720.24 KB 205.78% (🟢 -0.01%)
/(main)/backoffice/issue/[id]/page 53.07 KB 207.53 KB 59.29% (🟢 -0.01%)
/(main)/backoffice/rewards_pending/page 57.14 KB 211.6 KB 60.46% (🟢 -0.02%)
/(main)/backoffice/pledges/page 55.33 KB 209.79 KB 59.94% (🟢 -0.01%)
/(main)/backoffice/badge/page 43.13 KB 197.59 KB 56.45% (🟢 -0.01%)
/(main)/dashboard/layout 359 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/docs/layout 361 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/(landing)/page 491.78 KB 646.24 KB 184.64% (🟢 -0.01%)
/(main)/(landing)/layout 208.03 KB 362.49 KB 103.57% (🟢 -0.01%)
/(main)/(topbar)/(backer)/purchases/license-keys/page 88.59 KB 243.05 KB 69.44% (🟢 -0.01%)
/(main)/(topbar)/(backer)/layout 79.2 KB 233.66 KB 66.76% (🟢 -0.01%)
/(main)/(topbar)/(backer)/purchases/page 361 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/products/page 88.67 KB 243.13 KB 69.47% (🟢 -0.02%)
/(main)/(topbar)/(backer)/purchases/subscriptions/[id]/page 199.79 KB 354.25 KB 101.21% (🟢 -0.01%)
/(main)/(topbar)/(backer)/purchases/subscriptions/page 88.55 KB 243.01 KB 69.43% (🟢 -0.01%)
/(main)/(topbar)/(backer)/purchases/products/[id]/page 195.44 KB 349.9 KB 99.97% (🟢 -0.01%)
/(main)/(topbar)/(backer)/settings/page 251.88 KB 406.33 KB 116.10% (🟢 -0.02%)
/(main)/(topbar)/(backer)/purchases/file-downloads/page 174.6 KB 329.06 KB 94.02% (🟢 -0.02%)
/(main)/dashboard/(create)/create/page 151.32 KB 305.78 KB 87.36% (🟢 -0.01%)
/(main)/dashboard/(create)/layout 359 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/dashboard/[organization]/storefront/page 374.25 KB 528.71 KB 151.06% (🟢 -0.01%)
/(main)/dashboard/[organization]/layout 45.62 KB 200.08 KB 57.16% (🟢 -0.01%)
/(main)/(landing)/(mdx)/blog/(header)/mitchell-hashimoto-joins-polar-as-an-advisor/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/(landing)/(mdx)/careers/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/better-pricing/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/(mdx)/countries/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/(mdx)/customers/purchases/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/(mdx)/fees/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/(mdx)/github/funding-yaml/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/(mdx)/onboarding/page 179.41 KB 333.86 KB 95.39% (🟢 -0.01%)
/(main)/docs/(mdx)/merchant-of-record/compliance/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/api/(mdx)/authentication/page 226.47 KB 380.93 KB 108.84% (🟢 -0.02%)
/(main)/docs/developers/guides/page 362 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/docs/developers/guides/node/page 33.58 KB 188.04 KB 53.73% (+/- <0.01%)
/(main)/docs/developers/open-source/page 33.58 KB 188.04 KB 53.73% (+/- <0.01%)
/(main)/docs/developers/sdk/checkout-link/page 33.58 KB 188.04 KB 53.73% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-init/page 33.58 KB 188.04 KB 53.73% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-migrate/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/developers/sdk/typescript/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/support/(mdx)/page 33.09 KB 187.55 KB 53.59% (+/- <0.01%)
/(main)/docs/developers/webhooks/events/page 361 B 154.81 KB 44.23% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/rewards/page 113.62 KB 268.08 KB 76.59% (🟢 -0.01%)
/(main)/(topbar)/(backer)/finance/layout 213.44 KB 367.9 KB 105.12% (🟢 -0.02%)
/(main)/(topbar)/(backer)/finance/outgoing/page 183.82 KB 338.28 KB 96.65% (🟢 -0.01%)
/(main)/(topbar)/(backer)/finance/incoming/page 234.61 KB 389.07 KB 111.16% (🟢 -0.01%)
/(main)/(topbar)/(backer)/(sidebar)/funding/page 247.14 KB 401.6 KB 114.74% (🟢 -0.01%)
/(main)/(topbar)/(backer)/(sidebar)/layout 135.04 KB 289.5 KB 82.71% (🟢 -0.01%)
/(main)/(topbar)/(backer)/finance/account/page 201.23 KB 355.69 KB 101.63% (🟢 -0.02%)
/(main)/dashboard/[organization]/(header)/customers/page 595.24 KB 749.7 KB 214.20% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/layout 565.78 KB 720.24 KB 205.78% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/benefits/page 658.89 KB 813.35 KB 232.39% (🟢 -0.04%)
/(main)/dashboard/[organization]/(header)/benefits/license-keys/page 592.73 KB 747.19 KB 213.48% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/issues/overview/page 608.75 KB 763.21 KB 218.06% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/issues/badge/page 593.38 KB 747.84 KB 213.67% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/initialize/page 145.62 KB 300.08 KB 85.74% (🟢 -0.02%)
/(main)/dashboard/[organization]/(header)/issues/organizations/page 568.15 KB 722.61 KB 206.46% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/issues/embed/page 568.24 KB 722.7 KB 206.49% (🟢 -0.02%)
/(main)/dashboard/[organization]/(header)/products/new/page 647.13 KB 801.59 KB 229.03% (🟢 -0.04%)
/(main)/dashboard/[organization]/(header)/members/page 566.65 KB 721.1 KB 206.03% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/products/page 594.94 KB 749.4 KB 214.11% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/products/[id]/page 654.93 KB 809.39 KB 231.25% (🟢 -0.03%)
/(main)/dashboard/[organization]/(header)/products/discounts/page 626.48 KB 780.94 KB 223.12% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/sales/[id]/page 579.05 KB 733.51 KB 209.57% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/products/benefits/page 658.42 KB 812.88 KB 232.25% (🟢 -0.04%)
/(main)/dashboard/[organization]/(header)/sales/subscriptions/page 595.45 KB 749.91 KB 214.26% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/sales/page 607.33 KB 761.79 KB 217.65% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/settings/page 585.26 KB 739.72 KB 211.35% (🟢 -0.02%)
/(main)/dashboard/[organization]/(header)/settings/custom-fields/page 598.04 KB 752.5 KB 215.00% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/page 579.63 KB 734.09 KB 209.74% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/endpoints/[id]/page 596.7 KB 751.16 KB 214.62% (🟢 -0.02%)
/(main)/dashboard/[organization]/(header)/(home)/page 655.12 KB 809.57 KB 231.31% (🟢 -0.04%)
/(main)/dashboard/[organization]/(header)/analytics/page 696.19 KB 850.65 KB 243.04% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/finance/incoming/page 184.57 KB 339.03 KB 96.87% (🟢 -0.02%)
/(main)/dashboard/[organization]/(header)/finance/layout 565.79 KB 720.25 KB 205.78% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/finance/account/page 151.33 KB 305.79 KB 87.37% (🟢 -0.02%)
/(main)/dashboard/[organization]/(header)/finance/outgoing/page 133.77 KB 288.23 KB 82.35% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/contributors/page 63.43 KB 217.89 KB 62.25% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/layout 565.79 KB 720.24 KB 205.78% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/rewarded/page 63.42 KB 217.88 KB 62.25% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/page 64.14 KB 218.6 KB 62.46% (🟢 -0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@frankie567 frankie567 merged commit 2d55075 into main Dec 17, 2024
12 of 15 checks passed
@frankie567 frankie567 deleted the fix/4613 branch December 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tax: Move setting to products vs. benefits alone
1 participant
@frankie567