server: Allow reused customer email after deletion

server/polar/customer/service.py

@@ -156,7 +156,7 @@ async def update(
     async def delete(self, session: AsyncSession, customer: Customer) -> Customer:
         # TODO: cancel subscriptions, revoke benefits, etc.
 
-        customer.set_deleted_at()
+        customer.mark_deleted()
         session.add(customer)
         return customer
 

server/polar/models/customer.py

@@ -157,3 +157,11 @@ def legacy_user_public_name(self) -> str:
         if self.name:
             return self.name[0]
         return self.email[0]
+
+    def mark_deleted(self) -> None:
+        # We do soft deletes (transaction records).
+        # So prefix email as deleted to free up the real one for future purchases.
+        now = int(time.time())
+        email = f"deleted.{now}.{self.email}"
+        self.email = email
+        self.set_deleted_at()

server/tests/customer/test_service.py

@@ -10,6 +10,8 @@
 from polar.models import Customer, Organization, User, UserOrganization
 from polar.postgres import AsyncSession
 from tests.fixtures.auth import AuthSubjectFixture
+from tests.fixtures.database import SaveFixture
+from tests.fixtures.random_objects import create_customer
 
 
 @pytest.fixture
@@ -122,3 +124,56 @@ async def test_valid(
 
         assert customer.email == email
         assert customer.name == "John"
+
+
+@pytest.mark.asyncio
+class TestDelete:
+
+    async def test_valid(
+        self,
+        session: AsyncSession,
+        save_fixture: SaveFixture,
+        organization: Organization,
+        customer: Customer,
+    ) -> None:
+        customer = await create_customer(
+            save_fixture,
+            organization=organization,
+            email="[email protected]",
+        )
+        customer = await customer_service.delete(
+            session,
+            customer,
+        )
+        await session.flush()
+        assert customer.deleted_at is not None
+
+    async def test_valid_recreation(
+        self,
+        session: AsyncSession,
+        save_fixture: SaveFixture,
+        organization: Organization,
+        customer: Customer,
+    ) -> None:
+        email = "[email protected]"
+        customer = await create_customer(
+            save_fixture,
+            organization=organization,
+            email=email,
+        )
+        customer = await customer_service.delete(
+            session,
+            customer,
+        )
+
+        assert customer.deleted_at is not None
+        assert customer.email.startswith("deleted.")
+        assert customer.email.endswith(email)
+        await session.commit()
+
+        recreated = await create_customer(
+            save_fixture,
+            organization=organization,
+            email=email,
+        )
+        assert recreated