Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: clean up txPool even on error #914

Merged
merged 1 commit into from
Jun 26, 2024
Merged

*: clean up txPool even on error #914

merged 1 commit into from
Jun 26, 2024

Conversation

asubiotto
Copy link
Member

@asubiotto asubiotto commented Jun 25, 2024

This would otherwise leak goroutines if an error was encountered closing the WAL.

Bug found with DST.

This would otherwise leak goroutines if an error was encountered closing the
WAL.
Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find again!

@asubiotto asubiotto merged commit 56013c3 into main Jun 26, 2024
8 checks passed
@asubiotto asubiotto deleted the alfonso-txpool branch June 26, 2024 17:23
@asubiotto asubiotto mentioned this pull request Jun 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants