Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Propagate null instead of panicking in pl.repeat_by() #20787

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(python): Propagate null instead of panicking in pl.repeat_by() #20787

wants to merge 4 commits into from
+17 −6

Conversation

etiennebacher
Copy link
Contributor

Fixes #20268

@etiennebacher etiennebacher changed the title fix: Propagate null instead of panicking in pl.repeat_by() fix(python, rust): Propagate null instead of panicking in pl.repeat_by() Jan 18, 2025
@etiennebacher etiennebacher changed the title fix(python, rust): Propagate null instead of panicking in pl.repeat_by() fix(python): Propagate null instead of panicking in pl.repeat_by() Jan 18, 2025
@etiennebacher etiennebacher changed the title fix(python): Propagate null instead of panicking in pl.repeat_by() fix(python): Propagate null instead of panicking in pl.repeat_by() Jan 18, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Jan 18, 2025
@etiennebacher etiennebacher changed the title fix(python): Propagate null instead of panicking in pl.repeat_by() fix(python, rust): Propagate null instead of panicking in pl.repeat_by() Jan 18, 2025
@etiennebacher etiennebacher changed the title fix(python, rust): Propagate null instead of panicking in pl.repeat_by() fix(python): Propagate null instead of panicking in pl.repeat_by() Jan 18, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (d9f3e3d) to head (f15481f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20787      +/-   ##
==========================================
- Coverage   79.78%   79.78%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      221982   221980       -2     
  Branches     2531     2531              
==========================================
- Hits       177107   177105       -2     
  Misses      44293    44293              
  Partials      582      582

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repeat_by panics when n=lit(None); should propagate null instead
1 participant
@etiennebacher