Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust,python): Add quantiles method to expression list namespace #20782

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Feiyang472
Copy link

We would like to add a .quantile method for the list namespace.
This is a natural extension from the median method.

Please let me know where best to add unittests/doctests

@Feiyang472 Feiyang472 changed the title list namespace quantile method feat(rust, python): list namespace quantile method Jan 18, 2025
@Feiyang472 Feiyang472 marked this pull request as ready for review January 18, 2025 15:00
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 71.27660% with 27 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (87b03aa) to head (645956a).

Files with missing lines Patch % Lines
...es/polars-ops/src/chunked_array/list/dispersion.rs 72.50% 11 Missing ⚠️
.../polars-core/src/series/implementations/decimal.rs 0.00% 5 Missing ⚠️
...s-arrow/src/legacy/kernels/rolling/no_nulls/mod.rs 0.00% 4 Missing ⚠️
crates/polars-core/src/series/series_trait.rs 0.00% 3 Missing ⚠️
...polars-core/src/series/implementations/duration.rs 80.00% 1 Missing ⚠️
...s/polars-core/src/series/implementations/floats.rs 80.00% 1 Missing ⚠️
...ates/polars-core/src/series/implementations/mod.rs 80.00% 1 Missing ⚠️
crates/polars-plan/src/dsl/function_expr/list.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20782   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files        1561     1561           
  Lines      222001   222095   +94     
  Branches     2531     2531           
=======================================
+ Hits       177117   177193   +76     
- Misses      44302    44320   +18     
  Partials      582      582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Feiyang472 Feiyang472 changed the title feat(rust, python): list namespace quantile method feat(rust, python): Add quantiles method to expression list namespace Jan 19, 2025
@Feiyang472 Feiyang472 changed the title feat(rust, python): Add quantiles method to expression list namespace feat(rust,python): Add quantiles method to expression list namespace Jan 19, 2025
@Feiyang472 Feiyang472 changed the title feat(rust,python): Add quantiles method to expression list namespace feat(rust,python): Add quantiles method to expression list namespace Jan 19, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jan 19, 2025
@Feiyang472
Copy link
Author

the python3.9 test failure seems to have been resolved since #20776, I have merged with main head to rerun the CI pipes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant