-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust,python): Add quantiles method to expression list namespace #20782
Open
Feiyang472
wants to merge
11
commits into
pola-rs:main
Choose a base branch
from
Feiyang472:polars-py-list-quantile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+211
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang472
changed the title
list namespace quantile method
feat(rust, python): list namespace quantile method
Jan 18, 2025
Feiyang472
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
January 18, 2025 15:00
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20782 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 1561 1561
Lines 222001 222095 +94
Branches 2531 2531
=======================================
+ Hits 177117 177193 +76
- Misses 44302 44320 +18
Partials 582 582 ☔ View full report in Codecov by Sentry. |
Feiyang472
changed the title
feat(rust, python): list namespace quantile method
feat(rust, python): Add quantiles method to expression list namespace
Jan 19, 2025
Feiyang472
changed the title
feat(rust, python): Add quantiles method to expression list namespace
feat(rust,python): Add quantiles method to expression list namespace
Jan 19, 2025
Feiyang472
changed the title
feat(rust,python): Add quantiles method to expression list namespace
feat(rust,python): Add quantiles method to expression list namespace
Jan 19, 2025
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
and removed
title needs formatting
labels
Jan 19, 2025
the python3.9 test failure seems to have been resolved since #20776, I have merged with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to add a
.quantile
method for the list namespace.This is a natural extension from the
median
method.Please let me know where best to add unittests/doctests