Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support numerical arrays in bin.reinterpret #20456

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

balbok0
Copy link
Contributor

@balbok0 balbok0 commented Dec 25, 2024

Follow-up to: #20263 Related to: #18991

Adds support for casting binary into arrays of known size. This includes nested shapes (using flattening and reshaping).

Note that unknown size arrays (i.e. lists) are not supported. I think this is fine, since in majority of cases array size is known.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 78.80795% with 32 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (a6fffd4) to head (820e44b).

Files with missing lines Patch % Lines
crates/polars-core/src/datatypes/dtype.rs 34.21% 25 Missing ⚠️
...c/chunked_array/binary/cast_binary_to_numerical.rs 92.30% 4 Missing ⚠️
...s/polars-ops/src/chunked_array/binary/namespace.rs 92.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #20456    +/-   ##
========================================
  Coverage   79.00%   79.00%            
========================================
  Files        1563     1563            
  Lines      220449   220587   +138     
  Branches     2488     2488            
========================================
+ Hits       174157   174271   +114     
- Misses      45719    45743    +24     
  Partials      573      573            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant