Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add a TypeCheckRule to the optimizer #20425

Merged
merged 4 commits into from
Dec 24, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change to private parameter
coastalwhite committed Dec 24, 2024
commit 000e8b5c1b9868c8dc6c0997a44897b12b74bf4b
16 changes: 6 additions & 10 deletions py-polars/polars/functions/lazy.py
Original file line number Diff line number Diff line change
@@ -1619,7 +1619,7 @@ def collect_all(
lazy_frames: Iterable[LazyFrame],
*,
type_coercion: bool = True,
type_check: bool = True,
_type_check: bool = True,
predicate_pushdown: bool = True,
projection_pushdown: bool = True,
simplify_expression: bool = True,
@@ -1643,8 +1643,6 @@ def collect_all(
A list of LazyFrames to collect.
type_coercion
Do type coercion optimization.
type_check
Do type checking of the intermediate representation.
predicate_pushdown
Do predicate pushdown optimization.
projection_pushdown
@@ -1699,7 +1697,7 @@ def collect_all(
for lf in lazy_frames:
ldf = lf._ldf.optimization_toggle(
type_coercion,
type_check,
_type_check,
predicate_pushdown,
projection_pushdown,
simplify_expression,
@@ -1729,7 +1727,7 @@ def collect_all_async(
*,
gevent: Literal[True],
type_coercion: bool = True,
type_check: bool = True,
_type_check: bool = True,
predicate_pushdown: bool = True,
projection_pushdown: bool = True,
simplify_expression: bool = True,
@@ -1749,7 +1747,7 @@ def collect_all_async(
*,
gevent: Literal[False] = False,
type_coercion: bool = True,
type_check: bool = True,
_type_check: bool = True,
predicate_pushdown: bool = True,
projection_pushdown: bool = True,
simplify_expression: bool = True,
@@ -1769,7 +1767,7 @@ def collect_all_async(
*,
gevent: bool = False,
type_coercion: bool = True,
type_check: bool = True,
_type_check: bool = True,
predicate_pushdown: bool = True,
projection_pushdown: bool = True,
simplify_expression: bool = True,
@@ -1804,8 +1802,6 @@ def collect_all_async(
Return wrapper to `gevent.event.AsyncResult` instead of Awaitable
type_coercion
Do type coercion optimization.
type_check
Do type checking of the intermediate representation.
predicate_pushdown
Do predicate pushdown optimization.
projection_pushdown
@@ -1872,7 +1868,7 @@ def collect_all_async(
for lf in lazy_frames:
ldf = lf._ldf.optimization_toggle(
type_coercion,
type_check,
_type_check,
predicate_pushdown,
projection_pushdown,
simplify_expression,
Loading