feat: Support max/min method for Time dtype #19815
Open
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19815 +/- ##
==========================================
- Coverage 78.95% 78.95% -0.01%
==========================================
Files 1561 1561
Lines 219913 219921 +8
Branches 2471 2471
==========================================
+ Hits 173643 173644 +1
- Misses 45702 45709 +7
Partials 568 568 ☔ View full report in Codecov by Sentry. |
mcrumiller
reviewed
Nov 17, 2024
eitsupi
force-pushed
the
max-min-time
branch
2 times, most recently
from
bd66968 to
ef67aaf
Compare
eitsupi
force-pushed
the
max-min-time
branch
from
ef67aaf to
a7f8cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by #19494 (comment)
Since there are explicit upper and lower limits for the Time type in the Apache Arrow specification1, it may be useful to call them here.
Footnotes
https://github.com/apache/arrow/blob/e79f65cbd7851a9c4abdde81bf444b6d6b1de1bb/format/Schema.fbs#L258-L275 ↩