Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Share source token between all sender tasks of source nodes in new-streaming engine #19593

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Nov 1, 2024

This ensures a stop request is propagated to all tasks as soon as possible.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Nov 1, 2024
@orlp orlp force-pushed the source-token-share branch from 1985a70 to 1972eac Compare November 1, 2024 15:46
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (40f8f5d) to head (1972eac).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/in_memory_source.rs 0.00% 2 Missing ⚠️
...ates/polars-stream/src/nodes/parquet_source/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19593      +/-   ##
==========================================
- Coverage   79.83%   79.83%   -0.01%     
==========================================
  Files        1536     1536              
  Lines      211354   211357       +3     
  Branches     2445     2445              
==========================================
- Hits       168745   168744       -1     
- Misses      42054    42058       +4     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1d5c640 into pola-rs:main Nov 1, 2024
20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants