Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't panic in SQL temporal string check; raise suitable ColumnNotFound error #19473

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Oct 27, 2024

Closes #19426.

Fixes a rogue unwrap and adds some test coverage.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 27, 2024
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Oct 27, 2024
@alexander-beedie alexander-beedie changed the title fix: Fix potential SQL panic in temporal string check; raise suitable ColumnNotFound error instead fix: Don't panic in SQL temporal string check; raise suitable ColumnNotFound error Oct 27, 2024
@ritchie46 ritchie46 merged commit f103fa8 into pola-rs:main Oct 27, 2024
29 checks passed
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (e7a84bc) to head (2958b57).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-sql/src/sql_expr.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19473   +/-   ##
=======================================
  Coverage   79.94%   79.94%           
=======================================
  Files        1534     1534           
  Lines      211183   211229   +46     
  Branches     2444     2445    +1     
=======================================
+ Hits       168831   168873   +42     
- Misses      41797    41801    +4     
  Partials      555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie alexander-beedie deleted the sql-invalid-col-panic branch October 27, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when executing sql expression with invalid column
2 participants