feat: Improve read_database
typing
#19444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request aims to improve type hints in the codebase.
query
parameter inread_database
currently accepts onlystr
andSelectable
types, butexecute
can handlestr | TextClause | Selectable
.read_database
can execute successfully with aTextClause
argument.Changes Made
text
to validate thatread_database
executes properly with aTextClause
: 4e87f01query
parameter inread_database
to includeTextClause
: edd7e1d