Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve read_database typing #19444

Conversation

wakabame
Copy link
Contributor

@wakabame wakabame commented Oct 25, 2024

Purpose

This pull request aims to improve type hints in the codebase.

Changes Made

  • Added a test case that uses SQLAlchemy's text to validate that read_database executes properly with a TextClause: 4e87f01
  • Updated the type hint for the query parameter in read_database to include TextClause: edd7e1d

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 25, 2024
@wakabame wakabame marked this pull request as ready for review October 25, 2024 08:58
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (425e251) to head (edd7e1d).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19444   +/-   ##
=======================================
  Coverage   79.96%   79.97%           
=======================================
  Files        1534     1534           
  Lines      211030   211030           
  Branches     2444     2444           
=======================================
+ Hits       168750   168765   +15     
+ Misses      41725    41710   -15     
  Partials      555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie
Copy link
Collaborator

Yup, looks good to me - nice contribution 👍
(FYI: the failing doctest was addressed by #19440).

@alexander-beedie alexander-beedie merged commit 687811d into pola-rs:main Oct 27, 2024
13 of 14 checks passed
@wakabame wakabame deleted the feature/accept-textclause-sqlalchemy-read-database branch October 28, 2024 00:40
@wakabame
Copy link
Contributor Author

@alexander-beedie
Thank you for reviewing and approving my PR!
I appreciate your time and feedback. Looking forward to contributing more.

@alexander-beedie
Copy link
Collaborator

@alexander-beedie Thank you for reviewing and approving my PR! I appreciate your time and feedback. Looking forward to contributing more.

大歓迎です! ご貢献を楽しみにしています (^_^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants