Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add functionality for supporting the GPU engine on Polars Cloud #19362

Merged
merged 4 commits into from
Oct 22, 2024
Merged

feat: Add functionality for supporting the GPU engine on Polars Cloud #19362

merged 4 commits into from
Oct 22, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Oct 21, 2024 •
edited
Loading

This allows us to execute an IRPlan on the GPU engine on a Polars Cloud worker.

@stinodego stinodego added the skip changelog Do not include in changelog label Oct 21, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 21, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.08475% with 56 lines in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (eb596c9) to head (db137a8).
Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/cloud.rs 0.00% 56 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #19362      +/-   ##
==========================================
- Coverage   80.19%   80.17%   -0.02%     
==========================================
  Files        1523     1523              
  Lines      209853   209912      +59     
  Branches     2434     2434              
==========================================
+ Hits       168300   168307       +7     
- Misses      40998    41050      +52     
  Partials      555      555

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review October 22, 2024 10:59
@ritchie46 ritchie46 merged commit b9fd730 into main Oct 22, 2024
27 of 28 checks passed
@ritchie46 ritchie46 deleted the cloud-gpu-support branch October 22, 2024 17:21
@c-peters c-peters added the accepted Ready for implementation label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp

Assignees

@stinodego stinodego

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars skip changelog Do not include in changelog
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stinodego @ritchie46 @c-peters