Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add streaming groupby for reductions #19291

Merged
merged 19 commits into from
Oct 23, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 17, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 17, 2024
@orlp orlp force-pushed the streaming-groupby branch from 6f3ad9b to 471046b Compare October 18, 2024 10:30
@orlp orlp marked this pull request as ready for review October 18, 2024 13:31
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 27.55102% with 426 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (c8aac32) to head (dde43a9).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/group_by.rs 0.00% 139 Missing ⚠️
crates/polars-expr/src/groups/row_encoded.rs 0.00% 135 Missing ⚠️
crates/polars-core/src/series/mod.rs 0.00% 46 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 25 Missing ⚠️
crates/polars-core/src/datatypes/dtype.rs 0.00% 17 Missing ⚠️
crates/polars-core/src/frame/mod.rs 0.00% 17 Missing ⚠️
...-core/src/chunked_array/logical/categorical/mod.rs 0.00% 10 Missing ⚠️
crates/polars-expr/src/groups/mod.rs 0.00% 10 Missing ⚠️
...es/polars-core/src/chunked_array/ops/row_encode.rs 94.54% 9 Missing ⚠️
crates/polars-core/src/schema.rs 0.00% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19291      +/-   ##
==========================================
- Coverage   80.19%   80.03%   -0.17%     
==========================================
  Files        1527     1532       +5     
  Lines      210286   210708     +422     
  Branches     2440     2440              
==========================================
- Hits       168648   168635      -13     
- Misses      41083    41518     +435     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp force-pushed the streaming-groupby branch from 95278b9 to 90b45c6 Compare October 23, 2024 13:23
@orlp orlp merged commit 4cfe56f into pola-rs:main Oct 23, 2024
24 checks passed
@c-peters c-peters added the accepted Ready for implementation label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants