fix: Fix parsing of bytes to work for any valid numbers. For now fixed to low endianness #18992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balbok0
changed the title
github-actions
bot
added
fix
|
As mentioned in the linked issue I would rather see this feature removed and re-introduced with a dedicated API rather than casts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #18991 for more details.
One potential regression is that binary of exact size is required for parsing to work, which is not necessarily that can with previous function. I do think introducing this requirement makes sense though.
I was also unsure whether it's ok to remove dependency or not, so feel free to lmk if I should adjust Cargo.toml as well.