Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Add storage_options hint for azure #18990

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

francesco086
Copy link

Following issue #18931.

I've tried to find a good place to put some hints in the documentation, but I can't find a good place in the polars documentation without ruining the nice minimalist style.

I am trying with a PR to add it in the only place I consider acceptable.

@francesco086 francesco086 changed the title docs: add storage_options hint for azure docs(python): add storage_options hint for azure Sep 28, 2024
@francesco086 francesco086 changed the title docs(python): add storage_options hint for azure docs(python): Add storage_options hint for azure Sep 28, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars and removed title needs formatting labels Sep 28, 2024
@francesco086
Copy link
Author

francesco086 commented Sep 28, 2024

One more comment from a user perspective.

Azure users are used to adlfs and it is extremely common (and best practice for security) to use the anon=False option to use an identity based authentication. What is nice about it, is that it will resolve automatically which identity to use.

Object Store does not offer the same functionality, which is really a pity, and therefore switching to polars has been quite confusing for me.
The solution I found is not as good as what adlfs offers, but it's the best I found.

In conclusion, I think many Azure users who want to use polars keeping in mind best security standards will encounter this issue, and I think some hints could spare them some troubles.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (901b243) to head (143d64e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18990      +/-   ##
==========================================
- Coverage   79.88%   79.87%   -0.02%     
==========================================
  Files        1524     1524              
  Lines      207634   207634              
  Branches     2904     2904              
==========================================
- Hits       165873   165847      -26     
- Misses      41214    41240      +26     
  Partials      547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

I think this is good, but could you do the same for gcp and aws?

@francesco086
Copy link
Author

I think this is good, but could you do the same for gcp and aws?

I agree that it would make a lot of sense and I would love to contribute, but I have always worked with Azure and am not familiar with gcp and aws. I have had a look at their respective ConfigKey and for example I could not see the CLI option.
So I think it would be better if someone who works with these two clouds could contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants