Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Window function had incorrect output name on ExprIR #18970

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 27, 2024

No description provided.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (a030634) to head (ee91baf).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/expr_ir.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #18970    +/-   ##
========================================
  Coverage   79.85%   79.85%            
========================================
  Files        1523     1523            
  Lines      207315   207504   +189     
  Branches     2906     2904     -2     
========================================
+ Hits       165557   165709   +152     
- Misses      41210    41248    +38     
+ Partials      548      547     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 538fd6c into pola-rs:main Sep 27, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants