fix: Throw informative error for 0-width Array #18929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This not only affects the example given in the issue but also just provides a generally better error. Fixes pola-rs#18921.
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18929 +/- ##
==========================================
- Coverage 79.88% 79.86% -0.02%
==========================================
Files 1521 1521
Lines 206850 206853 +3
Branches 2906 2906
==========================================
- Hits 165243 165207 -36
- Misses 41059 41098 +39
Partials 548 548 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Sep 26, 2024
| @@ -372,6 +372,11 @@ impl Series { | |||
| pub fn cast_with_options(&self, dtype: &DataType, options: CastOptions) -> PolarsResult<Self> { | |||
| use DataType as D; | |||
|
|
|||
| #[cfg(feature = "dtype-array")] | |||
| if matches!(dtype, D::Array(_, width) if *width == 0) { | |||
There was a problem hiding this comment.
Can we fail a bit lower? Maybe in the array cast kernel?
There was a problem hiding this comment.
I started looking yesterday at just implementing zero-width arrays. It is almost done so this PR is not really needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only affects the example given in the issue but also just provides a generally better error.
Fixes #18921.