-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add allow_missing_columns
option to read/scan_parquet
#18922
feat: Add allow_missing_columns
option to read/scan_parquet
#18922
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18922 +/- ##
==========================================
+ Coverage 79.88% 80.03% +0.14%
==========================================
Files 1521 1523 +2
Lines 206849 208786 +1937
Branches 2906 2906
==========================================
+ Hits 165238 167092 +1854
- Misses 41063 41146 +83
Partials 548 548 ☔ View full report in Codecov by Sentry. |
@@ -384,20 +391,30 @@ fn rg_to_dfs_prefiltered( | |||
.then(|| calc_prefilter_cost(&filter_mask)) | |||
.unwrap_or_default(); | |||
|
|||
#[cfg(debug_assertions)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if cfg!(debug_assertions)
I bumped the minor version for |
I feel like |
How about Including the word "rows" in the parameter name feels a bit off, as it's really a column-oriented parameter 🤔 |
Yeah, let's go for that one. And default to |
I think this should also be added to read_parquet if possible |
null_rows_for_missing_columns
option to scan_parquet
allow_missing_columns
option to read/scan_parquet
I present a magic trick that adds it by changing the title of the PR 😀 |
Some technical detail - we do this by making our decode functions (i.e. |
Nice, can we also refer to the solution in the error when the schema resolving fails in strict mode? |
Let me know if there is a better name for this parameter