chore(python): Enable additional ruff
lint rule sets
#18721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was adding a lot of additional linting at work, and saw some value in enabling a few additional
ruff
rule sets here too.Additional rule sets
Various minor nitpicks/consistency (eg: we sometimes did and sometimes didn't annotate the return from
__init__
methods with-> None
, and now we do so consistently everywhere), and so on. Nothing that looks especially controversial ;)Some decent catches too, such as properly typing the return from context manager
__enter__
with-> Self
, and a few unnecessary list/dict comprehensions were spotted and suggested for optimisation.Also
ruff
(from "0.6.3" to "0.6.4").