refactor(rust): Make no-default-features compile #17516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlp
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
internal
wence-
reviewed
Jul 9, 2024
| @@ -328,6 +329,7 @@ pub(crate) fn into_py(py: Python<'_>, plan: &IR) -> PyResult<PyObject> { | |||
| .map_err(|err| PyValueError::new_err(format!("{err:?}")))?; | |||
| ("csv", options, cloud_options).into_py(py) | |||
| }, | |||
| #[cfg(feature = "parquet")] | |||
There was a problem hiding this comment.
question: Does feature="parquet" imply feature="serde" such that serde_json is available?
(Thanks for this, btw!)
There was a problem hiding this comment.
Nope, it doesn't, there's still various issues if you only compile with --no-default-features --features parquet.
But that's for a future follow-up PR. I want to tackle this in bits.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17516 +/- ##
==========================================
- Coverage 80.47% 80.47% -0.01%
==========================================
Files 1482 1482
Lines 195119 195119
Branches 2778 2778
==========================================
- Hits 157026 157021 -5
- Misses 37582 37587 +5
Partials 511 511 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.