Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Add allow_nan parameter to parametric testing series() and dataframes() functions #17188

Closed
wants to merge 1 commit into from

Conversation

mcrumiller
Copy link
Contributor

The allow_nan parameter wasn't being passed through to the underlying floats function via the series and dataframes parametric functions.

I did not update the docstrings because allow_nan is a dtype-specific parameter and it looks like the general docstrings for series and dataframes only include the parameters applicable to all dtypes.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 25, 2024
@mcrumiller mcrumiller force-pushed the allow-nan branch 2 times, most recently from e93abd3 to f15bac6 Compare June 25, 2024 13:21
@mcrumiller mcrumiller marked this pull request as ready for review June 25, 2024 13:30
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (7a1be3b) to head (f15bac6).

Files Patch % Lines
...olars/polars/testing/parametric/strategies/core.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17188      +/-   ##
==========================================
- Coverage   80.84%   80.83%   -0.02%     
==========================================
  Files        1464     1464              
  Lines      192016   192022       +6     
  Branches     2743     2745       +2     
==========================================
- Hits       155243   155212      -31     
- Misses      36262    36298      +36     
- Partials      511      512       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego
Copy link
Contributor

I really don't want to add this at this point. I have to rethink the design a bit and I don't want to take on more complexity before I do. The allow_infinity that you see is more of a backwards compatibility thing - that's not really the way this should work IMO.

We need to go for more of a composable setup. You can already get allow_nan functionality by using st.floats directly as the strategy of a column.

I'm sorry but I'm closing this one for now.

@stinodego stinodego closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants