Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Update implementation of Enum support in lit to address spurious test failure #17187

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

stinodego
Copy link
Contributor

This is a bit of a weird one - I saw spurious failures on this Enum functionality which shouldn't have any randomness at all, e.g.:
https://github.com/pola-rs/polars/actions/runs/9661447486/job/26649165757?pr=17164

Hoping this new implementation takes care of it.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jun 25, 2024
@stinodego stinodego marked this pull request as ready for review June 25, 2024 12:51
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.82%. Comparing base (7a1be3b) to head (d6b4c64).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17187      +/-   ##
==========================================
- Coverage   80.84%   80.82%   -0.03%     
==========================================
  Files        1464     1464              
  Lines      192016   192016              
  Branches     2743     2744       +1     
==========================================
- Hits       155243   155195      -48     
- Misses      36262    36310      +48     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Should we ensure we pass strings?

@stinodego
Copy link
Contributor Author

Should we ensure we pass strings?

We already do... But Enum categories subclass string which makes them weird. I still have no clue how this could fail only sometimes... but new implementation should be better since it explicitly extracts the Enum value.

@ritchie46 ritchie46 merged commit 240f92a into main Jun 25, 2024
15 checks passed
@ritchie46 ritchie46 deleted the enum-fix branch June 25, 2024 18:44
@c-peters c-peters added the accepted Ready for implementation label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants