feat: Exclude directories from glob expansion result #17174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
nameexhaustion
force-pushed
the
glob-dir-excl
branch
from
28f8da7 to
a262cc0
Compare
nameexhaustion
commented
Jun 25, 2024
| .then(|entry| async { Ok::<_, PolarsError>(entry.map_err(to_compute_err)?.location) }) | ||
| .filter(|name| ready(name.as_ref().map_or(true, |name| matcher.is_matching(name)))) | ||
| .try_collect() | ||
| .await?; | ||
| locations.sort_unstable(); |
There was a problem hiding this comment.
We did not previously use this function async fn glob in our test suite even with FORCE_ASYNC, but in this PR we do, which led to lots of test failures as the files were not read in a consistent order due to not being sorted.
nameexhaustion
commented
Jun 25, 2024
| #[cfg(not(feature = "cloud"))] | ||
| { | ||
| panic!("activate cloud feature") | ||
| } | ||
|
|
||
| #[cfg(feature = "cloud")] | ||
| { | ||
| if !is_cloud && verbose { | ||
| if force_async && verbose { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nameexhaustion
force-pushed
the
glob-dir-excl
branch
from
c8de205 to
07c8012
Compare
nameexhaustion
commented
Jun 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17174 +/- ##
==========================================
+ Coverage 80.82% 80.85% +0.02%
==========================================
Files 1466 1466
Lines 192313 192378 +65
Branches 2745 2745
==========================================
+ Hits 155446 155553 +107
+ Misses 36364 36322 -42
Partials 503 503 ☔ View full report in Codecov by Sentry. |
nameexhaustion
force-pushed
the
glob-dir-excl
branch
from
c57de81 to
d5a82fc
Compare
nameexhaustion
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Jun 28, 2024
| @@ -164,7 +164,6 @@ impl Matcher { | |||
| } | |||
| } | |||
|
|
|||
| #[tokio::main(flavor = "current_thread")] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17105