-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(python): Add description and example of what happens when ignore_nulls=True on pl.concat_str #16889
base: main
Are you sure you want to change the base?
docs(python): Add description and example of what happens when ignore_nulls=True on pl.concat_str #16889
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16889 +/- ##
==========================================
- Coverage 81.33% 80.84% -0.49%
==========================================
Files 1425 1466 +41
Lines 187867 192324 +4457
Branches 2702 2745 +43
==========================================
+ Hits 152797 155481 +2684
- Misses 34574 36340 +1766
- Partials 496 503 +7 ☔ View full report in Codecov by Sentry. |
@DeflateAwning does this address the issue? |
The example looks great! Assuming executing that example works as indicated, I believe your description is actually wrong. You wrote:
In reality:
Issues:
|
Good catch; I wasn't thinking about the separator. I corrected the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Request final review and, if approved, merging on this PR. It was endorsed by the original requestor. Thanks! |
Addresses #16814 on https://docs.pola.rs/py-polars/html/reference/expressions/api/polars.concat_str.html#polars.concat_str. (Other than changing the font, which is a larger decision.)