refactor(rust): Add fundamentals for new async-based streaming execution engine #16884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
CodSpeed Performance ReportMerging #16884 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16884 +/- ##
==========================================
+ Coverage 81.41% 81.42% +0.01%
==========================================
Files 1425 1425
Lines 187964 187973 +9
Branches 2704 2704
==========================================
+ Hits 153022 153056 +34
+ Misses 34445 34420 -25
Partials 497 497 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jun 12, 2024
|
|
||
| fn global() -> &'static Executor { | ||
| GLOBAL_SCHEDULER.get_or_init(|| { | ||
| let mut n_threads = NUM_EXECUTOR_THREADS.load(Ordering::Relaxed); |
There was a problem hiding this comment.
This should respect the POLARS_MAX_THREADS env var if set.
There was a problem hiding this comment.
I'd prefer if we keep Polars-specific stuff out of the executor itself, we'll just call executor::set_num_threads.
There was a problem hiding this comment.
Then that is a note to us that we must do that on startup or query conversion.
stinodego
changed the title
stinodego
removed
the
enhancement
stinodego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the codebase (but yet in no way actually uses) a bespoke efficient async executor that supports task priority, as well as several async primitives which will be useful for implementing our async-based streaming execution engine ideas.