Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python)!: Set infer_schema_length as keyword-only argument in str.json_decode #16835

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

henryharbeck
Copy link
Contributor

Closes #13698

This is a breaking change. If a deprecation is desired first, let me know.

Similar to #7860, the use of this argument is much more natural as a keyword argument, so impact should be limited.
Also stated there, these are hard to properly deprecate due to the Series -> Expr dispatch.

@github-actions github-actions bot added breaking Change that breaks backwards compatibility internal An internal refactor or improvement python Related to Python Polars labels Jun 9, 2024
@stinodego stinodego changed the title refactor(python)!: Set infer_schema_length as keyword-only for Series / Expr.str.json_decode refactor(python)!: Set infer_schema_length as keyword-only for str.json_decode Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.37%. Comparing base (c81ef69) to head (bbdc1f6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16835      +/-   ##
==========================================
- Coverage   81.38%   81.37%   -0.01%     
==========================================
  Files        1425     1425              
  Lines      187606   187606              
  Branches     2697     2697              
==========================================
- Hits       152677   152665      -12     
- Misses      34434    34446      +12     
  Partials      495      495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter does not technically need to be keyword-only here, but it is everywhere else. So marking them as such here is appropriate, I think.

Deprecation is not required at this point due to low impact.

@ritchie46 ritchie46 merged commit ceed90f into pola-rs:main Jun 9, 2024
16 checks passed
@stinodego stinodego changed the title refactor(python)!: Set infer_schema_length as keyword-only for str.json_decode refactor(python)!: Set infer_schema_length as keyword-only argument in str.json_decode Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Change that breaks backwards compatibility internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the infer_schema_length parameter only ever keyword only (for all functions/methods)
3 participants