depr(python): Rename SQLContext "eager_execution" param to "eager"
#16595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
deprecation
|
@stinodego: Ok, here's the deprecation-only PR - if you can merge this one in then I'll rebase the breaking follow-up on top of it 😎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16595 +/- ##
=======================================
Coverage 81.51% 81.51%
=======================================
Files 1414 1414
Lines 185714 185716 +2
Branches 3008 3009 +1
=======================================
+ Hits 151385 151388 +3
+ Misses 33813 33812 -1
Partials 516 516 ☔ View full report in Codecov by Sentry. |
stinodego
reviewed
May 30, 2024
stinodego
approved these changes
May 30, 2024
stinodego
changed the title
SQLContext "eager_execution" param to "eager"SQLContext "eager_execution" param to "eager"
|
Yep, agree with the rename. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #16594.
Split out the deprecation from the functional change; deprecates use of "eager_execution" in
SQLContextin favour of the more standard/idiomatic "eager".No functional changes, though I did remove the docstring examples that show multi-frame usage of
df.sqlandlf.sql, as that is going away in favour ofpl.sql.