Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash selecting columns after non-coalesced join #16541

Merged
merged 1 commit into from
May 28, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented May 28, 2024

Fixes #16515

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (ee377c7) to head (7aa6edb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16541      +/-   ##
==========================================
- Coverage   81.52%   81.52%   -0.01%     
==========================================
  Files        1412     1412              
  Lines      185257   185245      -12     
  Branches     2985     2985              
==========================================
- Hits       151030   151020      -10     
+ Misses      33709    33707       -2     
  Partials      518      518              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review May 28, 2024 09:23
@alexander-beedie alexander-beedie added A-sql Area: Polars SQL functionality and removed A-sql Area: Polars SQL functionality labels May 28, 2024
@ritchie46 ritchie46 merged commit 51bf030 into pola-rs:main May 28, 2024
28 checks passed
@nameexhaustion nameexhaustion deleted the join-1 branch May 29, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-join panic on select after joining on keys with different names with "coalesce=False"
3 participants