refactor(rust): Reorganize polars_io::csv module
#15831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15831 +/- ##
==========================================
- Coverage 80.39% 80.37% -0.03%
==========================================
Files 1263 1265 +2
Lines 165368 165391 +23
==========================================
- Hits 132942 132925 -17
- Misses 32426 32466 +40 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #15831 will not alter performanceComparing Summary
|
stinodego
changed the title
polars_io::csv modulepolars_io::csv module
github-actions
bot
added
the
breaking rust
stinodego
changed the title
polars_io::csv modulepolars_io::csv module
stinodego
removed
the
breaking rust
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
stinodego
commented
Apr 23, 2024
| @@ -3,7 +3,6 @@ | |||
| #![allow(clippy::transmute_undefined_repr)] | |||
| #![allow(non_local_definitions)] | |||
| #![allow(clippy::too_many_arguments)] // Python functions can have many arguments due to default arguments | |||
| extern crate polars as polars_rs; | |||
There was a problem hiding this comment.
Removed this as a drive-by. It was unnecessary and only used in a handful of places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DefaultforCsvParserOptions. No other functional changes.polars_io::csvmodule contents into two public submodules:readandwrite. Organized those modules and cleaned up the public exports.This is not breaking as the
polars::ionamespace should not be affected.Better use of the
optionsstructs will be up next 🤓