-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(rust): Fix incorrect column name in LazyFrame.sort
doc example
#15658
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15658 +/- ##
==========================================
- Coverage 81.33% 81.33% -0.01%
==========================================
Files 1374 1374
Lines 176471 176471
Branches 2544 2544
==========================================
- Hits 143539 143528 -11
- Misses 32450 32460 +10
- Partials 482 483 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #15658 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted! However, The example below is still using 'a', 'b' as columns. Better to just update the preceeding text "sort dataframe by sepal width column" to "Sort DataFrame by a single column". Then it all makes sense.
DataFrame.sort
doc example
DataFrame.sort
doc exampleLazyFrame.sort
doc example
Sure, I noticed there are 'sepal width' used elsewhere in the doc, if
that's not the consistency we're going to keep, the "a, b" treatment is
more clean and clear.
Stijn de Gooijer ***@***.***> 于 2024年4月16日周二 上午12:15写道:
… ***@***.**** requested changes on this pull request.
Well spotted! However, The example below is still using 'a', 'b' as
columns. Better to just update the preceeding text "sort dataframe by sepal
width column" to "Sort DataFrame by a single column".
—
Reply to this email directly, view it on GitHub
<#15658 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADDYEBTWXK42PKQCUBLOJN3Y5P4KFAVCNFSM6AAAAABGHBHUNCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBRGUZTQOBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
You're right. Then maybe update the last example to use |
Sure, then we stick to the iris dataset as before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw some inconsistency in using sepal.width
vs sepal_width
so I updated all references to use the same column names as the small dataset we have in the docs folder.
This can be merged, thanks 👍
#15590